Skip to content

buffer: remove unused param from copyActual#62042

Open
gurgunday wants to merge 1 commit intonodejs:mainfrom
gurgunday:remove-unused
Open

buffer: remove unused param from copyActual#62042
gurgunday wants to merge 1 commit intonodejs:mainfrom
gurgunday:remove-unused

Conversation

@gurgunday
Copy link
Member

Follow up to #61721

We added this quirky parameter in #60399 when implementing an optimization to Buffer.concat and Buffer.copy with the intention of eventually removing it when .concat used TypedArrayPrototypeSet in all cases

The parameter was only used in one place until it was removed in #61721:

https://github.com/nodejs/node/pull/61721/changes#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630L635

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Feb 28, 2026
@richardlau
Copy link
Member

This change is being made as part of #62032.

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (6a3d358) to head (ce5f8c4).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62042      +/-   ##
==========================================
+ Coverage   89.58%   89.64%   +0.06%     
==========================================
  Files         674      676       +2     
  Lines      205159   206240    +1081     
  Branches    39352    39506     +154     
==========================================
+ Hits       183792   184894    +1102     
+ Misses      13583    13465     -118     
- Partials     7784     7881      +97     
Files with missing lines Coverage Δ
lib/buffer.js 99.16% <100.00%> (ø)

... and 129 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gurgunday
Copy link
Member Author

@richardlau PTAL, that PR is closed for now

@gurgunday gurgunday added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/22575987214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants