Skip to content

test: avoid flaky restart sync in debugger exceptions test #62055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inoway46 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: avoid flaky restart sync in debugger exceptions test #62055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/parallel/test-debugger-exceptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const path = require('path');
await cli.waitFor(/disconnect/);

// Next run: With `breakOnException` it pauses in both places.
await cli.stepCommand('r');
await cli.command('r');
await cli.waitForInitialBreak();
assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
await cli.command('breakOnException');
Expand All @@ -38,15 +38,15 @@ const path = require('path');

// Next run: With `breakOnUncaught` it only pauses on the 2nd exception.
await cli.command('breakOnUncaught');
await cli.stepCommand('r'); // Also, the setting survives the restart.
await cli.command('r'); // Also, the setting survives the restart.
await cli.waitForInitialBreak();
assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
await cli.stepCommand('c');
assert.ok(cli.output.includes(`exception in ${script}:9`));

// Next run: Back to the initial state! It should die again.
await cli.command('breakOnNone');
await cli.stepCommand('r');
await cli.command('r');
await cli.waitForInitialBreak();
assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
await cli.command('c');
Expand Down
Loading