Skip to content

test_runner: fix run() isolation=none hang in cluster workers#62056

Draft
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-60020-run-none-teardown
Draft

test_runner: fix run() isolation=none hang in cluster workers#62056
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-60020-run-none-teardown

Conversation

@inoway46
Copy link
Contributor

@inoway46 inoway46 commented Mar 1, 2026

Summary

  • fix a hang in run() when using isolation=none in cluster workers
  • trigger teardown for run() API consumers without waiting on beforeExit
  • limit the explicit teardown path to run() API usage (!isTestRunner) to avoid changing node --test semantics
  • add a regression test for the cluster worker scenario

Test

  • ./tools/test.py test/parallel/test-runner-run.mjs
  • ./tools/test.py test/parallel/test-runner-extraneous-async-activity.js
  • ./tools/test.py test/parallel/test-runner-no-isolation.mjs test/parallel/test-runner-no-isolation-hooks.mjs

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants