Open
Conversation
Collaborator
|
Review requested:
|
Renegade334
reviewed
Mar 1, 2026
Member
Renegade334
left a comment
There was a problem hiding this comment.
I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62061 +/- ##
==========================================
- Coverage 89.74% 89.64% -0.11%
==========================================
Files 674 676 +2
Lines 204883 206242 +1359
Branches 39379 39506 +127
==========================================
+ Hits 183882 184889 +1007
- Misses 13279 13467 +188
- Partials 7722 7886 +164
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #61396