Skip to content

loader: enforce path normalization before lookup #63917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arcanis wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −0
Open

loader: enforce path normalization before lookup #63917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2811e40
loader: enforce path normalization before lookup
arcanis Jun 14, 2026
77b378e
Update test-require-package-map.js
arcanis Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/internal/modules/package_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ class PackageMap {
* @returns {string|null}
*/
#getKeyForPath(filePath) {
filePath = pathResolve(filePath);

const cached = this.#pathToKeyCache.get(filePath);
if (cached !== undefined) { return cached; }

Expand Down
16 changes: 16 additions & 0 deletions test/parallel/test-require-package-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,22 @@ describe('CJS: --experimental-package-map', { concurrency: !process.env.TEST_PAR
describe('longest path wins', () => {
const longestPathMap = fixtures.path('package-map/package-map-longest-path.json');

it('resolves from createRequire() paths with mixed separators', () => {
const { status, stdout, stderr } = spawnSync(process.execPath, [
'--no-warnings',
'--experimental-package-map', longestPathMap,
'-e',
`const { createRequire } = require('node:module'); const req = createRequire(process.cwd() + '/node_modules/inner/index.js'); const dep = req('dep-a'); console.log(dep.default);`,
], {
cwd: fixtures.path('package-map/root'),
encoding: 'utf8',
});

assert.strictEqual(stderr, '');
assert.match(stdout, /dep-a-value/);
assert.strictEqual(status, 0, stderr);
});

it('resolves nested package using its own dependencies, not the parent', () => {
// Inner lives at ./root/node_modules/inner which is inside root's
// path (./root). The longest matching path should win, so code in
Expand Down
Loading