net: multiple dtls improvements - #64314
Conversation
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
changed the title
7d55980 to
fe3087b
Compare
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Claude/Opus
fe3087b to
9953529
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: James M Snell <jasnell@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64314 +/- ##
==========================================
- Coverage 92.05% 90.25% -1.80%
==========================================
Files 381 741 +360
Lines 169394 240795 +71401
Branches 25970 45350 +19380
==========================================
+ Hits 155935 217340 +61405
- Misses 13169 15045 +1876
- Partials 290 8410 +8120
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
commit-queue
jasnell
added
the
author ready
nodejs-github-bot
removed
the
commit-queue
jasnell
added
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/64314 ✔ Done loading data for nodejs/node/pull/64314 ----------------------------------- PR info ------------------------------------ Title net: multiple dtls improvements (#64314) Author James M Snell <jasnell@gmail.com> (@jasnell) Branch jasnell:jasnell/dtls-fixes -> nodejs:main Labels c++, lib / src, author ready, needs-ci Commits 12 - net: improve dtls cert verification - net: fixing up dtls details - net: fixup UAF in dtls - net: fix session leak in dtls - net: fixup failed-connect hang in dtls - net: fix dtls unhandled rejections - net: add missing dtls permission check - net: fix multiple minor dtls issues - net: improve dtls buffer handling - net: additional dtls fixups and tests - test: dtls test improvements - net: fixup dtls c++ formatting Committers 1 - James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 06 Jul 2026 03:40:57 GMT ✔ Approvals: 1 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/64314#pullrequestreview-4678903069 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-07-13T19:26:23Z: https://ci.nodejs.org/job/node-test-pull-request/74792/ - Querying data for job/node-test-pull-request/74792/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 64314 From https://github.com/nodejs/node * branch refs/pull/64314/merge -> FETCH_HEAD ✔ Fetched commits as a6a1bd4de0b6..d7ecfc44ee1a -------------------------------------------------------------------------------- [main 4f0604f0ed] net: improve dtls cert verification Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 18:30:17 2026 -0700 7 files changed, 201 insertions(+), 16 deletions(-) create mode 100644 test/parallel/test-dtls-verify-identity.mjs [main ef23197f9e] net: fixing up dtls details Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 18:44:05 2026 -0700 4 files changed, 32 insertions(+), 44 deletions(-) [main 22c0803c2b] net: fixup UAF in dtls Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 18:59:05 2026 -0700 2 files changed, 97 insertions(+) create mode 100644 test/parallel/test-dtls-destroy-in-callback.mjs [main 3b5ecf075d] net: fix session leak in dtls Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 19:33:57 2026 -0700 3 files changed, 99 insertions(+), 2 deletions(-) create mode 100644 test/parallel/test-dtls-session-table-cleanup.mjs [main d845c95614] net: fixup failed-connect hang in dtls Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 19:48:12 2026 -0700 2 files changed, 64 insertions(+) create mode 100644 test/parallel/test-dtls-connect-error-cleanup.mjs [main d358cce96c] net: fix dtls unhandled rejections Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 20:00:23 2026 -0700 2 files changed, 59 insertions(+) create mode 100644 test/parallel/test-dtls-unhandled-rejection.mjs [main a3256d49ac] net: add missing dtls permission check Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 20:06:59 2026 -0700 2 files changed, 12 insertions(+), 2 deletions(-) [main 918877c3be] net: fix multiple minor dtls issues Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 20:21:29 2026 -0700 4 files changed, 100 insertions(+), 33 deletions(-) create mode 100644 test/parallel/test-dtls-servername-invalid.mjs [main 6aefef8f27] net: improve dtls buffer handling Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 20:31:03 2026 -0700 3 files changed, 21 insertions(+), 9 deletions(-) Auto-merging test/parallel/test-dtls-alpn.mjs [main b5654297b1] net: additional dtls fixups and tests Author: James M Snell <jasnell@gmail.com> Date: Sun Jul 5 21:13:30 2026 -0700 8 files changed, 98 insertions(+), 29 deletions(-) create mode 100644 test/parallel/test-dtls-srtp.mjs Auto-merging test/parallel/test-dtls-alpn.mjs Auto-merging test/parallel/test-dtls-options.mjs [main 35314dccdf] test: dtls test improvements Author: James M Snell <jasnell@gmail.com> Date: Mon Jul 6 07:26:27 2026 -0700 14 files changed, 697 insertions(+), 7 deletions(-) create mode 100644 test/parallel/test-dtls-accessors.mjs create mode 100644 test/parallel/test-dtls-ciphers.mjs create mode 100644 test/parallel/test-dtls-client-cert.mjs create mode 100644 test/parallel/test-dtls-errors.mjs create mode 100644 test/parallel/test-dtls-keylog.mjs create mode 100644 test/parallel/test-dtls-mtu.mjs create mode 100644 test/parallel/test-dtls-reject-unauthorized.mjs create mode 100644 test/parallel/test-dtls-robustness.mjs create mode 100644 test/parallel/test-dtls-send.mjs [main 78e4aece2a] net: fixup dtls c++ formatting Author: James M Snell <jasnell@gmail.com> Date: Tue Jul 7 06:53:01 2026 -0700 1 file changed, 1 insertion(+), 2 deletions(-) ✔ Patches applied There are 12 commits in the PR. Attempting autorebase. (node:357) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/24) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- net: improve dtls cert verificationhttps://github.com/nodejs/node/actions/runs/30685262905 |
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a7d16a8 |
|
When this PR landed, it showed linting errors running https://github.com/nodejs/node/actions/runs/30687387385/job/91335821935 This is affecting other commits landing in Edit: #64902 is targeted to fix the linting |
4 participants
Multiple DTLS improvements.
Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Claude/Opus