quic: serialize stream reset code as string - #64577
Merged
nodejs-github-bot merged 1 commit intoJul 27, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64577 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 741 741
Lines 242112 242112
Branches 45605 45591 -14
==========================================
- Hits 218244 218233 -11
Misses 15360 15360
- Partials 8508 8519 +11
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 19, 2026
bjohansebas
approved these changes
Jul 19, 2026
pimterry
approved these changes
Jul 20, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Ethan-Arrowood
approved these changes
Jul 23, 2026
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
Contributor
There was a problem hiding this comment.
CI failure doesn't seem related to changes here. Can you rebase onto latest main, and then we'll try request-ci again? Thanks!
Signed-off-by: manNomi <hanmw110@naver.com>
manNomi
force-pushed
the
quic-serialize-stream-reset-code
branch
from
July 23, 2026 05:13
83661c1 to
bbe85a3
Compare
pimterry
approved these changes
Jul 23, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
mertcanaltin
approved these changes
Jul 24, 2026
pimterry
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 58795e9 |
aduh95
pushed a commit
that referenced
this pull request
Aug 3, 2026
Signed-off-by: manNomi <hanmw110@naver.com> PR-URL: #64577 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QuicStreamState.toJSON()returnedresetCodeas aBigInt.QuicStreamState.toString()serializes that object withJSONStringify(), so serializing a live stream state threwTypeError: Do not know how to serialize a BigInt. CallingJSON.stringify()on the state failed for the same reason.Serialize
resetCodeas a string, matching the handling of other 64-bitQUIC state values. Using a string also preserves values outside JavaScript's
safe integer range. This only changes the JSON representation; it does not
change QUIC stream reset processing or the stored reset code.
Add a regression assertion that serializes a stream state and verifies the
parsed
resetCodevalue.