Skip to content

fix(a11y): add lang attribute to language selector for better SR accessibility #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShubhamOulkar wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −5
Open

fix(a11y): add lang attribute to language selector for better SR accessibility #8689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2b03f8
fix(ui-components): implement hrefLang in language selector for bette…
ShubhamOulkar Mar 3, 2026
5728559
test(ui-components): update language selector stories with localized …
ShubhamOulkar Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions packages/ui-components/src/Common/LanguageDropDown/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,32 @@ type Meta = MetaObj<typeof LanguageDropDown>;
export const Default: Story = {
args: {
availableLanguages: [
{ name: 'English', code: 'en', localName: 'English' },
{ name: 'French', code: 'fr', localName: 'Français' },
{ name: 'Spanish', code: 'es', localName: 'Español' },
{ name: 'English', code: 'en', localName: 'English', hrefLang: 'en-GB' },
{ name: 'French', code: 'fr', localName: 'Français', hrefLang: 'fr' },
{ name: 'Spanish', code: 'es', localName: 'Español', hrefLang: 'es-ES' },
{ name: 'Japanese', code: 'ja', localName: '日本語', hrefLang: 'ja' },
{
name: 'Simplified Chinese',
code: 'zh-cn',
localName: '简体中文',
hrefLang: 'zh-Hans',
},
{
name: 'Traditional Chinese',
code: 'zh-tw',
localName: '繁體中文',
hrefLang: 'zh-Hant',
},
],
currentLanguage: 'en',
},
};

export const Japanese: Story = {
args: {
...Default.args,
currentLanguage: 'ja',
},
};

export default { component: LanguageDropDown } as Meta;
5 changes: 3 additions & 2 deletions packages/ui-components/src/Common/LanguageDropDown/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ const LanguageDropdown: FC<LanguageDropDownProps> = ({
sideOffset={5}
>
<div>
{availableLanguages.map(({ name, code, localName }) => (
{availableLanguages.map(({ name, code, localName, hrefLang }) => (
<DropdownMenu.Item
key={code}
onClick={() => onChange({ name, code, localName })}
lang={hrefLang}
onClick={() => onChange({ name, code, localName, hrefLang })}
className={classNames(styles.dropDownItem, {
[styles.currentDropDown]: code === currentLanguage,
})}
Expand Down
1 change: 1 addition & 0 deletions packages/ui-components/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ export type SimpleLocaleConfig = {
code: string;
localName: string;
name: string;
hrefLang: string;
};
Loading