fix: preserve queued request ordering after stream body errors#5336
Closed
mcollina wants to merge 1 commit into
Closed
fix: preserve queued request ordering after stream body errors#5336mcollina wants to merge 1 commit into
mcollina wants to merge 1 commit into
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
ronag
reviewed
May 29, 2026
Comment on lines
-1091
to
-1095
| if (body && typeof body.read === 'function') { | ||
| // Try to read EOF in order to get length. | ||
| body.read(0) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
this is problematic in some cases...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readablebody probing before undici attaches body/error handlersclient-errorsexpectations for the failed POST / queued GET orderingFixes #5335.
Testing
node --test --test-reporter=spec --test-timeout=180000 test/node-test/client-errors.js~/.nvm/versions/node/v25.2.1/bin/node --test --test-reporter=spec --test-timeout=180000 test/node-test/client-errors.js~/.nvm/versions/node/v26.1.0/bin/node --test --test-reporter=spec --test-timeout=180000 test/node-test/client-errors.jsPATH="$HOME/.nvm/versions/node/v26.1.0/bin:$PATH" npm run test:node-testnpx eslint lib/dispatcher/client-h1.js test/node-test/client-errors.js