feat: Enhanced certificate handling, improved ergonomics, and documentation#13
Merged
Conversation
- Quote shell variables in ci.yml to fix shellcheck warnings (GITHUB_ACTIONS) - Disable TYPESCRIPT_STANDARD validation since project uses ESLint+Prettier
The test was checking $RUNNER_TEMP but the action writes to ~/.appstoreconnect/private_keys/ Now uses the action's output to get the correct key path
Remove node-forge fallback - OpenSSL is more robust and available on all macOS runners. Version detection for -legacy flag is preserved.
2873c09 to
6314bea
Compare
nodeselector
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates enhancements across three key areas: documentation, certificate handling, and action ergonomics.
Documentation
apple_codesigning_overview.md: Comprehensive guide explaining Apple code signing concepts, certificate types, provisioning profiles, and common workflowsREADME.md: Improved usage examples and clearer documentation of action inputs/outputsEnhanced Certificate Handling
P12 and PEM Format Support
Encrypted Private Key Support
Smart Base64 Detection
Simplified P12 to PEM Conversion
importCertificateFromP12Buffermethod for cleaner codebaseAction Ergonomics
Default Combined Setup Mode
asset-typeinputAutomatic Keychain Password Generation
Some CI Fixes
Testing