Open
Conversation
Contributor
Author
|
@TomAFrench I added an explanation in the context so you could double-check. |
|
@kashbrti and I discussed the issue about range constraints and concluded that things are fine as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes Schnorr library to use Poseidon hash instead of pederson + blake.
This is a breaking change and any code using this library has to be updated.
Problem*
Resolves
Summary*
Additional Context
I'm unsure about whether we would need to range constraint the
sig_einassert_valid_signature. I have convinced myself that this can not be an issue, sincecalculate_signature_challengescalculates e with a poseidon hash and if thesig_ebyte value is wrapping, it wouldn't match.More concretely the sig_e and e should match both modulo BN254_Fq and BN254_Fr (one in the msm the other in the validity check).
PR Checklist*
cargo fmton default settings.