Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
old eventsの予定をドラッグ&ドロップにより複製した際に,モーダルを表示するようにした.
モーダルでは以下の変更を行えるようにした.
予定を複製する際,元の予定の
recurrence_idと同じ値をもつように予定を複製していた.また,予定を新規作成する際,
recurrence_idにはRecurrence.inbox.idを与えていた.これは,作成された予定はまずはinboxに属するものとして,その後,整理することを想定していたと考えられる.
カレンダでold eventsから予定を複製することを考えた場合,新規予定作成時に予定に固有の
recurrence_idを与えておく必要がある.この理由は,新規作成した予定は既存のリカーレンスに属さず,リカーレンスに属する予定はold eventsから複製すると考えられるためである.
このため,予定を新規作成する際,
recurrence_idにはEventオブジェクトのidを与えることにした.