Open
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #10 「ビュレットの調整」に対してのPR
概要
項番付きリストに入れ子で項番なしリストを用いると後続の文字がビュレットに重なる問題があった.
この問題の発生原因としては,HTML,CSS の項番付きリストを非表示にし,jay のライブラリ(markdown_converter.rb)で項番付きリストの項番のインクリメント,生成を行っていた.
これによって,項番付きリストの左にマージンが生じていたため,CSS で list-item を左にずらしていた.
これが項番なしリストにも影響し,今回の問題が発生していた.
解決法
本 PR での解決策として,markdown_converter.rb で項番を生成するのではなく,本来のHTML,CSS で項番を表示することでビュレットを調整した.