Fix: add duration to status for audio files - #13
Open
Technici4n wants to merge 3 commits into
Open
Conversation
depuits
reviewed
Jun 4, 2017
| fullscreen: (parseInt(data.match(/ANS_VO_FULLSCREEN=([01])/)[1]) === 1), | ||
| subtitles: (parseInt(data.match(/ANS_SUB_VISIBILITY=([01])/)[1]) === 1) | ||
| }); | ||
| if(data.indexOf('ANS_LENGTH') !== -1 || data.indexOf('ANS_VO_FULLSCREEN') !== -1 || data.indexOf('ANS_SUB_VISIBILITY') !== -1) { |
There was a problem hiding this comment.
This or check seems completly unnesesary because the checks are repeated for each item below
Author
There was a problem hiding this comment.
Indeed. Do you want me to remove it ?
There was a problem hiding this comment.
I would remove it but there still needs to be a check for calling the setStatus so it isn't called when nothing is changed
Varpars as maps dont have a length value, but you can get the keys and work with them.
Fixed Maps for setOption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, the duration in the status object is 0 for audio files. Now the correct duration is displayed. For video files, it shouldn't matter anyways.