Skip to content

fix(fastpath): floor single-PR implementation tier at sonnet (B7/#303) - #304

Merged
norrietaylor merged 1 commit into
mainfrom
fix/303-fastpath-tier-floor
Jun 19, 2026
Merged

fix(fastpath): floor single-PR implementation tier at sonnet (B7/#303)#304
norrietaylor merged 1 commit into
mainfrom
fix/303-fastpath-tier-floor

Conversation

@norrietaylor

Copy link
Copy Markdown
Owner

Fixes #303.

Problem

With B3 fixed, the fast-path single-PR implementation dispatches — but no-ops on the haiku tier: sdd-execute-haiku doesn't follow the situation-1a fast-path entry (read the plan comment, implement) and emits zero safe outputs, so no impl PR and the tracking issue stalls at sdd:in-progress. Sonnet executes the identical entry reliably (proven by the full-path run #39 and the spike execute, both sonnet).

Fix (surgical, no recompile)

In .github/actions/sdd-fastpath-approve/action.yml, at the single point where the plan's model: tier becomes the dispatch (const tierlet tier), map a haiku classification up to sonnet. tier is the sole input to both the dispatched workflow name and the aw_context tier:, so this floors only the fast-path single-PR implementation. Full-path cascade tiering never flows through this action; sonnet/opus pass through unchanged.

This is a composite action referenced @main by wrappers/sdd-spec.yml — not embedded in any .lock.yml, so no lock recompile.

Verification

YAML valid; embedded github-script JS syntactically clean (async-wrapped node --check). Scope confirmed: tier is used only in this dispatch step; the action appears in zero lock files.

Alternative considered: strengthen situation-1a prose / forbid model:haiku in the classifier — rejected as fuzzier and (for the prose) a 219KB-lock recompile. The tier-floor is deterministic and localized.

🤖 Generated with Claude Code

The fast-path single-PR implementation no-ops on the haiku tier: the
sdd-execute-haiku agent doesn't follow the situation-1a fast-path entry (read
the plan comment via plan_comment_id and implement) and emits zero safe outputs
— no impl PR, tracking issue stranded at sdd:in-progress. Sonnet executes the
same entry reliably (proven by the full-path and spike-path runs, both sonnet).

Floor the fast-path implementation dispatch at sonnet: in sdd-fastpath-approve,
at the single point where the plan's model:* tier becomes the dispatch, map a
haiku classification up to sonnet. Only the fast-path single-PR implementation
is affected; full-path cascade tiering never flows through this action.
Composite action — no lock recompile.

Fixes #303.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3cefc035-08e9-48dc-a44f-852b880bb934

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

In .github/actions/sdd-fastpath-approve/action.yml, the tier variable is changed from immutable to mutable, and a conditional block is added that remaps a parsed haiku tier to sonnet (with a log line) before the sdd-execute-{tier}.yml workflow dispatch, ensuring the execute step never runs on the haiku tier.

Changes

Fast-path haiku→sonnet tier floor

Layer / File(s) Summary
Haiku-to-sonnet tier remapping at dispatch
.github/actions/sdd-fastpath-approve/action.yml
Converts the tier assignment to mutable and inserts a guard block: when the parsed plan tier is haiku, it is overwritten with sonnet and the adjustment is logged, so the subsequent sdd-execute-{tier}.yml dispatch always receives sonnet instead of haiku.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A haiku said "hello?"
and did nothing at all,
so Sonnet stepped in — wrote the code, fixed the call.
Now the fast path completes
with a PR and cheer,
one small floor-check, and the rabbit hops clear! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(fastpath): floor single-PR implementation tier at sonnet (B7/#303)' accurately and specifically describes the main change: mapping haiku tier to sonnet in the fast-path approve action.
Description check ✅ Passed The description comprehensively explains the problem (haiku no-ops on fast-path execute), the surgical fix (tier mapping in action.yml), and verification approach—all directly related to the changeset.
Linked Issues check ✅ Passed The PR directly addresses issue #303 by implementing option 2 (raise tier floor) to fix haiku no-op behavior, mapping haiku to sonnet in the dispatch point as specified in the issue discussion.
Out of Scope Changes check ✅ Passed The single file change (.github/actions/sdd-fastpath-approve/action.yml) is narrowly scoped to the tier mapping at the dispatch point, with no extraneous modifications or policy changes to other systems.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/303-fastpath-tier-floor

Comment @coderabbitai help to get the list of available commands and usage tips.

@norrietaylor

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@norrietaylor
norrietaylor merged commit f8aad26 into main Jun 19, 2026
13 checks passed
@norrietaylor
norrietaylor deleted the fix/303-fastpath-tier-floor branch June 19, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fast-path execute no-ops on the haiku tier: agent doesn't follow the situation-1a entry, emits zero outputs

1 participant