fix(fastpath): floor single-PR implementation tier at sonnet (B7/#303) - #304
Conversation
The fast-path single-PR implementation no-ops on the haiku tier: the sdd-execute-haiku agent doesn't follow the situation-1a fast-path entry (read the plan comment via plan_comment_id and implement) and emits zero safe outputs — no impl PR, tracking issue stranded at sdd:in-progress. Sonnet executes the same entry reliably (proven by the full-path and spike-path runs, both sonnet). Floor the fast-path implementation dispatch at sonnet: in sdd-fastpath-approve, at the single point where the plan's model:* tier becomes the dispatch, map a haiku classification up to sonnet. Only the fast-path single-PR implementation is affected; full-path cascade tiering never flows through this action. Composite action — no lock recompile. Fixes #303. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughIn ChangesFast-path haiku→sonnet tier floor
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Fixes #303.
Problem
With B3 fixed, the fast-path single-PR implementation dispatches — but no-ops on the haiku tier:
sdd-execute-haikudoesn't follow the situation-1a fast-path entry (read the plan comment, implement) and emits zero safe outputs, so no impl PR and the tracking issue stalls atsdd:in-progress. Sonnet executes the identical entry reliably (proven by the full-path run #39 and the spike execute, both sonnet).Fix (surgical, no recompile)
In
.github/actions/sdd-fastpath-approve/action.yml, at the single point where the plan'smodel:tier becomes the dispatch (const tier→let tier), map ahaikuclassification up tosonnet.tieris the sole input to both the dispatched workflow name and the aw_contexttier:, so this floors only the fast-path single-PR implementation. Full-path cascade tiering never flows through this action;sonnet/opuspass through unchanged.This is a composite action referenced
@mainbywrappers/sdd-spec.yml— not embedded in any.lock.yml, so no lock recompile.Verification
YAML valid; embedded github-script JS syntactically clean (async-wrapped
node --check). Scope confirmed:tieris used only in this dispatch step; the action appears in zero lock files.Alternative considered: strengthen situation-1a prose / forbid
model:haikuin the classifier — rejected as fuzzier and (for the prose) a 219KB-lock recompile. The tier-floor is deterministic and localized.🤖 Generated with Claude Code