fix(sdd-execute): install protobuf-compiler in host rust cleanup - #325
Conversation
The post-agent rust cleanup installs the Rust toolchain on the host runner but not protoc. The refresh step's `cargo clippy` compiles the workspace and runs build scripts; crates using prost/tonic shell out to `protoc`, so a manifest-adding task that pulls a protobuf crate fails the refresh with "Could not find protoc" (seen on a consumer pilot run adding a WireGuard mesh dependency). Install protobuf-compiler best-effort, gated on the same Rust-edit detection; non-Debian hosts degrade to a warning so clippy fails loudly rather than this step erroring opaquely. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0143kv2BRrRqGxmVwwHskQtS
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughA new host post-step is added to ChangesRust Cleanup: protoc Install Step
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Root cause
shared/sdd-rust-cleanup.mdinstalls the Rust toolchain on the host runner but notprotoc.cargo clippy, which compiles the workspace + build scripts; prost/tonic crates shell out toprotocat build time.Could not find protoc(seen on a consumer pilot run adding a WireGuard mesh dep — the agent implemented the change but could not finalize the lock/lint cleanup, so the run produced no usable PR).Fix
Install protobuf-compiler (host)step after the Rust toolchain install, gated on the samecargo_detect.changed. Best-effort: skips ifprotocalready present, installs via apt on Debian hosts, warns otherwise so clippy fails loudly on a genuinely missing tool.Deploy
recompile-locksregenerates the threesdd-execute-*locks on merge to main (ADR 0018). Retagv0.3.0after the auto-recompile lands.🤖 Generated with Claude Code