contrib: migrate benchmarks from nightly libtest to criterion#1310
Open
TheAwiteb wants to merge 2 commits into
Open
contrib: migrate benchmarks from nightly libtest to criterion#1310TheAwiteb wants to merge 2 commits into
libtest to criterion#1310TheAwiteb wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
==========================================
- Coverage 69.75% 69.74% -0.01%
==========================================
Files 188 188
Lines 31391 31393 +2
==========================================
- Hits 21897 21896 -1
- Misses 9494 9497 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheAwiteb
force-pushed
the
criterion-for-benches
branch
5 times, most recently
from
f2e5418 to
bad3ba2
Compare
3 tasks
This commit moves the benchmark suite to `/benches` so it can be run with `cargo bench -p benches` on stable Rust. It also provides an HTML report in `target/criterion/report/index.html`. While porting, several bugs in the existing benchmarks were identified and fixed: - `public_key_to_hex`: was incorrectly benchmarking `PublicKey::to_bech32` instead of `PublicKey::to_hex`. - `tags_dedup_**_tags`: were deduplicating already-deduplicated tags; fixed by using `Bencher::iter_batched` to supply fresh tags each iteration. - `tags_pop` and `vec_tags_pop`: were popping from an already-empty collection; now reset the collection per iteration. - `tags_push` and `vec_tags_push`: were unnecessarily allocating on each iteration instead of reusing pre‑allocated space. Signed-off-by: Awiteb <a@4rs.nl>
TheAwiteb
force-pushed
the
criterion-for-benches
branch
from
bad3ba2 to
c2f4208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the benchmark suite to
/benchesso it can be run withcargo bench -p bencheson stable Rust. It also provides an HTML report intarget/criterion/report/index.html.While porting, several bugs in the existing benchmarks were identified and fixed:
public_key_to_hex: was incorrectly benchmarkingPublicKey::to_bech32instead ofPublicKey::to_hex.tags_dedup_**_tags: were deduplicating already-deduplicated tags; fixed by usingBencher::iter_batchedto supply fresh tags each iteration.tags_popandvec_tags_pop: were popping from an already-empty collection; now reset the collection per iteration.tags_pushandvec_tags_push: were unnecessarily allocating on each iteration instead of reusing pre‑allocated space.Notes to the reviewers
I exported
InnerRelayandInnerRelay::handle_raw_relay_messageifbenchis enabledChecklist