Skip to content

Keys drop #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yukibtc merged 2 commits into from
Jun 15, 2026
Merged

Keys drop #1379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f5226a
nostr: impl `Drop` for `Keys`
yukibtc Jun 13, 2026
f0c7169
nostr: remove `Keys::keypair` method
yukibtc Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions crates/nostr/src/key/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,6 @@ impl Keys {
&self.secret_key
}

/// Get keypair
#[inline]
pub fn keypair(&self) -> &Keypair {
&self.keypair
}

/// Creates a schnorr signature of the [`Message`].
///
/// This method uses a random number generator that retrieves randomness from the operating system (see [`SysRng`]).
Expand Down Expand Up @@ -265,6 +259,16 @@ impl FromStr for Keys {
}
}

impl Drop for Keys {
#[inline]
fn drop(&mut self) {
// Erase the keypair.
//
// NOTE: we already erase the secret key in 'impl Drop for SecretKey'.
self.keypair.non_secure_erase();
}
}

impl GetPublicKey for Keys {
type Error = Infallible;

Expand Down
Loading