Skip to content

Merge nostr-relay-builder into nostr-sdk#1387

Merged
yukibtc merged 3 commits into
nostrdevkit:masterfrom
yukibtc:sdk-local-relay
Jul 6, 2026
Merged

Merge nostr-relay-builder into nostr-sdk#1387
yukibtc merged 3 commits into
nostrdevkit:masterfrom
yukibtc:sdk-local-relay

Conversation

@yukibtc

@yukibtc yukibtc commented Jul 1, 2026

Copy link
Copy Markdown
Member

Description

Closes #1374

Checklist

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc yukibtc added this to the v0.45 milestone Jul 1, 2026
@yukibtc yukibtc requested a review from TheAwiteb as a code owner July 1, 2026 09:24
yukibtc added 2 commits July 1, 2026 11:25
Closes nostrdevkit#1374

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
…ocalRelay

This removes the `atomic-destructor` dependency and introduces a manual reference counting mechanism with `Arc<AtomicUsize>` for managing `LocalRelay` shutdown. Includes updated tests for shutdown behavior.

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc yukibtc force-pushed the sdk-local-relay branch from 9c3ae06 to d1666dc Compare July 1, 2026 09:25
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.40%. Comparing base (9df86d4) to head (d1666dc).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   76.32%   76.40%   +0.07%     
==========================================
  Files         196      197       +1     
  Lines       32660    32744      +84     
==========================================
+ Hits        24927    25017      +90     
+ Misses       7733     7727       -6     
Flag Coverage Δ
rust 76.40% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TheAwiteb TheAwiteb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@yukibtc yukibtc merged commit d1666dc into nostrdevkit:master Jul 6, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge nostr-relay-builder into the nostr-sdk

2 participants