This repository was archived by the owner on Jan 25, 2025. It is now read-only.
Add MultiPV support to uci.SearchResults#115
Open
cmitsakis wants to merge 6 commits intonotnil:masterfrom
Open
Add MultiPV support to uci.SearchResults#115cmitsakis wants to merge 6 commits intonotnil:masterfrom
cmitsakis wants to merge 6 commits intonotnil:masterfrom
Conversation
…sult scanner to make testing easier.
Author
|
kmorrison's implementation assumes the info line with |
|
Any progress on merging this? |
|
Hi, everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some more commits to PR #100
closes #99
In kmorrison's PR, I noticed is that if you do a MultiPV search,
eng.SearchResults().Infoshows the score of the last MultiPV result which is the worst move, so the score is wrong. I fixed this issue.I also changed the type of MultiPV from
[]*Infoto[]Info.