feat: add pagination and filter flags to all list commands#47
Merged
giordano-lucas merged 3 commits intomainfrom Feb 10, 2026
Merged
feat: add pagination and filter flags to all list commands#47giordano-lucas merged 3 commits intomainfrom
giordano-lucas merged 3 commits intomainfrom
Conversation
Expose --page, --page-size, and resource-specific filter flags (--only-active, --only-saved, --name) on all 7 paginated list commands so CLI users can paginate results and filter server-side instead of always fetching the first page with defaults. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
9
to
12
|
|
||
| func getPageFlag(cmd *cobra.Command) *int { | ||
| if cmd.Flags().Changed("page") { | ||
| v, _ := cmd.Flags().GetInt("page") |
There was a problem hiding this comment.
Invalid pagination defaults
registerPaginationFlags sets --page and --page-size defaults to 0, but the help string says page is 1-indexed. If a user passes --page 0 (or omits the flag and your API treats nil differently than 0), this can result in server-side validation errors or unexpected paging behavior. Consider either (a) defaulting to 1/a sensible page size, or (b) adding validation to reject values < 1 when the flag is provided.
getPageFlag and getPageSizeFlag now return errors when the user explicitly passes a value less than 1, preventing invalid requests to the API since pages are 1-indexed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose --page, --page-size, and resource-specific filter flags (--only-active, --only-saved, --name) on all 7 paginated list commands so CLI users can paginate results and filter server-side instead of always fetching the first page with defaults.
Greptile Overview
Greptile Summary
This PR threads pagination (
--page,--page-size) and resource-specific filters (e.g.--only-active,--only-saved,--name) through all paginatedlistcommands by adding shared flag helpers ininternal/cmd/pagination.goand wiring the resulting optional params into the generated API client request structs. It also updates CLI docs (README + skill references) and adds a unit test to ensure the expected flags are exposed on each list command.The main functional risk is around pagination semantics: the flags are documented as 1-indexed, but defaults/validation currently allow
0, which can lead to server-side errors or surprising behavior depending on how the API interprets omitted vs zero values.Confidence Score: 4/5
Important Files Changed