Open
Conversation
Any newer and the mystery importlib metadata error appears. Weird! >_>
Having two distinct test flavours is giving me a headache
Makes a VERY big image, I suspect we can optimise this a lot...
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| 'NAME': str(BASE_DIR / 'db.sqlite3'), | ||
| } | ||
| 'default': { | ||
| 'ENGINE': 'django.db.backends.{}'.format( |
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. Explained here.
Member
Author
There was a problem hiding this comment.
oh shut up you
Member
Author
|
Should look at updating python from 3.10 at some point too. And probably defining it in a single source of truth - currently it's manually defined in the dockerfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile is not very well optimised, it currently produces a 1.66GB image!!
Probably think about switching to using docker / postgres DB in development workflow, using sqlite has caused owt but problems in the past. Some work has been done to that end in this PR, much remains.
Caveat emptor