fix: wire AbortSignal to osascript subprocess for clean cancellation#80
fix: wire AbortSignal to osascript subprocess for clean cancellation#80ErnestHysa wants to merge 1 commit into
Conversation
…er picker, --no-open precedence Apply fixes from open upstream PRs that apply cleanly to our fork: - AbortSignal (nowork-studio#80, ErnestHysa): wire signal? parameter through pickFolder and pickFolderMac to execFile, enabling clean cancellation of osascript. Also extend to the new Linux execDialog helper. - Linux folder picker (nowork-studio#77, RohithVangalla1): implement pickFolderLinux using zenity (GTK) with kdialog (KDE) fallback, replacing the TODO stub. Linux users can now use the Browse button in the NotFair UI. - --no-open precedence (nowork-studio#92, Osamaali313): extract the auto-open guard in bin/notfair-content-calendar into a _should_auto_open helper that checks --no-open before platform. Fixes macOS/Windows ignoring the flag. Co-authored-by: Claude
…er picker, --no-open precedence Apply fixes from open upstream PRs that apply cleanly to our fork: - AbortSignal (nowork-studio#80, ErnestHysa): wire signal? parameter through pickFolder and pickFolderMac to execFile, enabling clean cancellation of osascript. Also extend to the new Linux execDialog helper. - Linux folder picker (nowork-studio#77, RohithVangalla1): implement pickFolderLinux using zenity (GTK) with kdialog (KDE) fallback, replacing the TODO stub. Linux users can now use the Browse button in the NotFair UI. - --no-open precedence (nowork-studio#92, Osamaali313): extract the auto-open guard in bin/notfair-content-calendar into a _should_auto_open helper that checks --no-open before platform. Fixes macOS/Windows ignoring the flag. Co-authored-by: Claude
|
Thanks for the PR — declining this one, with reasoning:
What would be a welcome resubmission: the complete end-to-end version against |
Fixes the AbortSignal not wired bug in pick-folder.ts. The osascript subprocess previously only had a 5-min hard timeout with no way to cancel it via AbortSignal. This change adds
signal?: AbortSignalsupport topickFolderand wires it toexecFilefor clean cancellation.