Changed serialization for OptionSingleChoice#115
Open
mikaczma wants to merge 1 commit intonpcole:masterfrom
Open
Changed serialization for OptionSingleChoice#115mikaczma wants to merge 1 commit intonpcole:masterfrom
mikaczma wants to merge 1 commit intonpcole:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed serialization for OptionSingleChoice as saved as list not single value.
When OptionList tries to save options to file SingleChoice option saves not single value but a list.
It cannot be serialized then and catches
AttributeError: 'OptionSingleChoice' object has no attribute 'decode'This issue can be solved or by changing serialization type (as i.e. MultiChoice) or add decode attribute to
OptionSingleChoice. IMO first option is more convenient as bothSingleChoiceandMultiChoiceinherits from_OptionLimitedChoices_