fix: workspace-filtered install with linked strategy#9041
Merged
owlstronaut merged 1 commit intolatestfrom Mar 2, 2026
Merged
Conversation
owlstronaut
force-pushed
the
owlstronaut/fix-install-links
branch
2 times, most recently
from
241f4d2 to
ea19365
Compare
Contributor
Author
|
@manzoorwanijk Could you give this a try? |
Contributor
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
Gave it a test and it works great. Thanks.
wraithgar
changed the title
wraithgar
reviewed
Mar 2, 2026
wraithgar
reviewed
Mar 2, 2026
owlstronaut
force-pushed
the
owlstronaut/fix-install-links
branch
from
ea19365 to
a37efed
Compare
wraithgar
approved these changes
Mar 2, 2026
| package: workspace.package, | ||
| linksIn: new Set(), | ||
| } | ||
| root.children.set(wsLink.name, wsLink) |
Contributor
There was a problem hiding this comment.
This seems to have introduced a new bug that creates duplicate symlinks and fails with EEXIST. I am investigating the issue. I will file a bug report when I find the cause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isolated tree created by _createIsolatedTree() used Arrays and plain objects incompatible with workspace-filtered installs. This caused crashes when using --workspace with --install-strategy=linked, broken since the linked strategy was introduced in npm 9.4.0.
Fixes: #9038