fix: Fixed an issue with files named node.js on Windows#64
Merged
Conversation
giovannicalo
changed the title
5 tasks
kevinoid
added a commit
to kevinoid/eslint-config-kevinoid
that referenced
this pull request
May 7, 2023
To avoid inadvertently running node.js (using Windows Script Host) instead of node.exe when .js is present in %PATHEXT% (as it is by default). The problem is exacerbated by a regression in .cmd shims generated by npm (npm/cmd-shim#64 npm/cmd-shim#71) and has already caused problems in CI (https://github.com/actions/setup-node/issues/720). Continue to export node and node.js from the package for backward compatibility. These may be removed in a future version. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Contributor
|
Sorry this got stale. Reopen a pr if it is still good/relevant |
kevinoid
added a commit
to kevinoid/setup-node-issue-720
that referenced
this pull request
Jun 10, 2026
See: npm/cmd-shim#71 See: npm/cmd-shim#64 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
|
@owlstronaut I can still reproduce the issue in echo #!/usr/bin/env node >mycommand.js
echo console.log('Success!') >>mycommand.js
md bin
node -e "require('cmd-shim')('mycommand.js', 'bin/mycommand')"
type nul >bin/node.js
cd bin
mycommandI can also confirm that this PR still applies cleanly and fixes the issue, as demonstrated by a Github Actions Workflow. I urge you to consider reopening and merging this PR. |
Contributor
|
@kevinoid great, I've reopened it. Happy to take a look when CI is happy :) |
Contributor
Author
|
It seems in the last 4 years a test has been added which my original commit didn't cover. I've updated the snapshot. It should pass now. |
owlstronaut
changed the title
owlstronaut
approved these changes
Jun 19, 2026
Merged
owlstronaut
pushed a commit
that referenced
this pull request
Jun 19, 2026
🤖 I have created a release *beep* *boop* --- ## [9.0.2](v9.0.1...v9.0.2) (2026-06-19) ### Bug Fixes * [`1c2f94c`](1c2f94c) [#64](#64) Fixed an issue with files named node.js on Windows (#64) (@giovannicalo) ### Chores * [`4f2209b`](4f2209b) [#185](#185) bump @npmcli/template-oss from 5.1.0 to 5.1.1 (#185) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Node module binary is run in a folder containing a file called
node.js, on Windows, that file will be opened instead of the binary.This happens due to Windows'
PATHEXTenvironment variable containing.JS.The issue was originally fixed in 8b1433c, but it has reappeared in c039646.
Currently,
endlocalis called after editingPATHEXTbut before invoking Node, so the latter is not affected by it.My solution edits
PATHEXTafter callingendlocal, thus affecting the Node invocation and fixing the issue.The only downside is the Node process will receive the edited
PATHEXT, which however must've been the original behaviour anyway.