Skip to content

fix: replace remaining built-in icons in chart context menus#1768

Open
graphieros wants to merge 3 commits intonpmx-dev:mainfrom
graphieros:main
Open

fix: replace remaining built-in icons in chart context menus#1768
graphieros wants to merge 3 commits intonpmx-dev:mainfrom
graphieros:main

Conversation

@graphieros
Copy link
Contributor

@graphieros graphieros commented Feb 28, 2026

Minor polishing: replaces remaining built-in icons in the charts context menus with lucide icons:

Main context menu: stack mode icon (chart with multiple series)

stack mode inactive stack-mode active
image image

Annotator context menu, icons for the various annotation modes:

arrow mode text mode straight line freehand
image image image image

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 28, 2026 11:08pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 28, 2026 11:08pm
npmx-lunaria Ignored Ignored Feb 28, 2026 11:08pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d822cc7 and a6b443d.

📒 Files selected for processing (2)
  • app/components/Package/TrendsChart.vue
  • app/components/Package/VersionDistribution.vue

📝 Walkthrough

Walkthrough

This pull request adds new icon templates to annotator UI elements across two Vue components. The TrendsChart.vue file receives an optionStack template that conditionally displays either a stack or chart-spline icon, and an annotator-action-draw template supporting four icon modes. The VersionDistribution.vue component receives a similar annotator-action-draw template with mode-specific icons for arrow, text, line, and draw actions. These changes expand the visual controls in the chart interfaces without modifying data retrieval or business logic.

Suggested reviewers

  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, detailing the replacement of built-in icons with lucide icons in chart context menus across the two modified Vue components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/VersionDistribution.vue 57.14% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@graphieros graphieros enabled auto-merge February 28, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant