Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a new AppMark component and updates header and page layouts to use it on mobile while keeping a resized AppLogo on desktop; restructures AppLogo SVG geometry; updates index page header spacing and badge position; swaps PWA asset references to logo-icon.svg; updates tests to include AppMark and to reflect the renamed asset in the file-tree fixture. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
would you mind resolving the conflict? 🙏 |
|
@danielroe Fixed! 7a0fc21 updated Then, as before, I renamed |
|
The test failures seem unrelated? |
|
seems a takumi/og image flakiness (cc: @harlan-zw) |
|
I'm sorry! reverted the og image change due to the flakiness (was also apparent per-route and on other PRs ...) |
🔗 Linked issue
It was easier to just create the PR to demonstrate the fix — hope that's okay.
🧭 Context
The logo, on the homepage, and in the navigation, had various issues. Most significantly, the kerning and spacing seemed wrong to me.
📚 Description
I've create a new logo SVG and applied it throughout the website. Here are the benefits, which are visible in the below screenshots. Please look at the screenshots in full size to be able to see the differences properly.
<path>s, ensuring the logo is rendered identically across all browsers.AppLogoand anAppMarkcomponent, making it easier to use either the full logo, or just the “./” mark.AppLogonow contains the full logo, allowing it to be more easily used across the website.AppLogopreviously incorrectly had a background colour and rounded corners, which has been fixed.logo.svgfile has been renamed tologo-icon.svg, creating space for the newlogo.svgwhich contains the full logo, andlogo-mark.svgwhich contains just the “./” mark on a transparent background. This should be handy for future use, in eg marketing materials.