Skip to content

fix: disable some keyboard shortcuts when it's disabled in settings #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex-key wants to merge 5 commits into
base: main
Choose a base branch
from
+11 −0
Open

fix: disable some keyboard shortcuts when it's disabled in settings #1780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2aec902
fix: disable some hot keys when disabled in settings
alex-key Mar 1, 2026
d881032
Merge branch 'main' into fix/some-shortkeys-work-when-disabled-in-set…
alex-key Mar 1, 2026
1f8c4d4
Merge branch 'main' of https://github.com/alex-key/npmx.dev into fix/…
alex-key Mar 2, 2026
ae6d424
fix: remove kbd settings check from Playgrounds
alex-key Mar 2, 2026
c265a93
Merge branch 'fix/some-shortkeys-work-when-disabled-in-settings' of h…
alex-key Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/components/Compare/PackageSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ const resultIndexOffset = computed(() => (showNoDependencyOption.value ? 1 : 0))

const numberFormatter = useNumberFormatter()

const keyboardShortcuts = useKeyboardShortcuts()

function addPackage(name: string) {
if (packages.value.length >= maxPackages.value) return
if (packages.value.includes(name)) return
Expand All @@ -98,6 +100,10 @@ function removePackage(name: string) {
}

function handleKeydown(e: KeyboardEvent) {
if (!keyboardShortcuts.value) {
return
}

const items = navigableItems.value
const count = items.length

Expand Down
5 changes: 5 additions & 0 deletions app/pages/search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,12 @@ function focusSearchInput() {
searchInput?.focus()
}

const keyboardShortcuts = useKeyboardShortcuts()

function handleResultsKeydown(e: KeyboardEvent) {
if (!keyboardShortcuts.value) {
return
}
// If the active element is an input, navigate to exact match or wait for results
if (e.key === 'Enter' && document.activeElement?.tagName === 'INPUT') {
// Get value directly from input (not from route query, which may be debounced)
Expand Down
Loading