Skip to content

fix: replace remaining built in icons in chart context menus #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphieros merged 2 commits into from
Mar 2, 2026
Merged

fix: replace remaining built in icons in chart context menus #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a2b22
fix: replace built-in icons with lucide icons in chart context menus
graphieros Mar 2, 2026
1c6240b
fix: set point-events-none on stack mode icons
graphieros Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions app/components/Package/TrendsChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,6 +2036,18 @@ watch(selectedMetric, value => {
<template #optionSvg>
<span class="text-fg-subtle font-mono pointer-events-none">SVG</span>
</template>
<template #optionStack="{ isStack }">
<span
v-if="isStack"
class="i-lucide:layers-2 text-fg-subtle w-6 h-6 pointer-events-none"
aria-hidden="true"
/>
<span
v-else
class="i-lucide:chart-line text-fg-subtle w-6 h-6 pointer-events-none"
aria-hidden="true"
/>
</template>

<template #annotator-action-close>
<span
Expand All @@ -2047,6 +2059,28 @@ watch(selectedMetric, value => {
<template #annotator-action-color="{ color }">
<span class="i-lucide:palette w-6 h-6" :style="{ color }" aria-hidden="true" />
</template>
<template #annotator-action-draw="{ mode }">
<span
v-if="mode === 'arrow'"
class="i-lucide:move-up-right text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
<span
v-if="mode === 'text'"
class="i-lucide:type text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
<span
v-if="mode === 'line'"
class="i-lucide:pen-line text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
<span
v-if="mode === 'draw'"
class="i-lucide:line-squiggle text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
</template>
<template #annotator-action-undo>
<span
class="i-lucide:undo-2 w-6 h-6 text-fg-subtle"
Expand Down
23 changes: 23 additions & 0 deletions app/components/Package/VersionDistribution.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,29 @@ const chartConfig = computed<VueUiXyConfig>(() => {
<span class="i-lucide:palette w-6 h-6" :style="{ color }" aria-hidden="true" />
</template>

<template #annotator-action-draw="{ mode }">
<span
v-if="mode === 'arrow'"
class="i-lucide:move-up-right text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
<span
v-if="mode === 'text'"
class="i-lucide:type text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
<span
v-if="mode === 'line'"
class="i-lucide:pen-line text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
<span
v-if="mode === 'draw'"
class="i-lucide:line-squiggle text-fg-subtle w-6 h-6"
aria-hidden="true"
/>
</template>

<template #annotator-action-undo>
<span
class="i-lucide:undo-2 w-6 h-6 text-fg-subtle"
Expand Down
Loading