lad regions#548
Conversation
Robinlovelace
commented
Oct 31, 2024
Robinlovelace
commented
- Update gitignore
- comment-out everything after school routing, for tests
- Testing pattern in targets
- Working dynamic branching (it seems)!
- Dynamic branching for commuting too
- Add garbage_collection
- Try lads as regions
|
The last commit above actually fixes an error and should be ported to main ASAP:
|
|
Hi @wangzhao0217 I think this is the way forward. Advantages of using LADs as regions for build:
There may also be some disadvantages. We will have to make changes to |
|
Any update on this @wangzhao0217 ? I should be able to have a bash later this evening or in the next few days. |
|
Failing for Clackmannshire @wangzhao0217 |
| tar_target(r_commute, | ||
| rs_commute[[1]]$routes, | ||
| pattern = map(rs_commute), | ||
| iteration = "list" | ||
| ), | ||
| tar_target(r_commute_fastest, { | ||
| rs_commute[[1]][[1]]$routes | ||
| }), | ||
| tar_target(r_commute_quietest, { | ||
| rs_commute[[3]][[1]]$routes | ||
| }), | ||
| tar_target(r_commute_ebike, { | ||
| rs_commute[[4]][[1]]$routes | ||
| }), | ||
| tar_target(r_commute_balanced, { | ||
| rs_commute[[2]][[1]]$routes | ||
| }), |
There was a problem hiding this comment.
This undoes the conciseness benefits of using dynamic branching, right?
wangzhao0217
force-pushed
the
lad-regions
branch
from
59a7eec to
b00c6e6
Compare
Robinlovelace
left a comment
Robinlovelace
left a comment
There was a problem hiding this comment.
Few more changes to minimize difference compared with main.
|
Plan for this: use this approach in January, deploy results on test website, and then merge if good, finally 🚀 |
| @@ -1,4 +1,9 @@ | |||
| nrow,plan,purpose,region,date,id | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Please tidy-up when you get a chance 🙏
wangzhao0217
force-pushed
the
lad-regions
branch
from
46d04e8 to
0341a26
Compare
2 participants
