Fix: Add bicycle_road tag to classification (issue #150)#151
Open
Robinlovelace wants to merge 1 commit intomainfrom
Open
Fix: Add bicycle_road tag to classification (issue #150)#151Robinlovelace wants to merge 1 commit intomainfrom
Robinlovelace wants to merge 1 commit intomainfrom
Conversation
- Added bicycle_road to et_active() to retrieve the tag from OSM - Added classification for bicycle_road=yes as 'Level track' - This ensures German bicycle roads (e.g., Munich) are classified correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #150 by adding support for the
bicycle_roadOSM tag.Changes
bicycle_roadtoet_active()- ensures the tag is retrieved from OSM databicycle_road=yesare now classified asLevel trackWhy
The
bicycle_roadtag is commonly used in Germany (e.g., Munich) to designate bicycle boulevards. Previously, these roads were not being classified in osmactive, causing them to be missed in analysis.Testing
Run osmactive on German cities (e.g., Munich) and verify that roads with
bicycle_road=yesare now included.Fixes #150