Update TrackAnalysis.js#836
Open
svmidi wants to merge 2 commits intonrenner:masterfrom
Open
Conversation
Added translation of track in analytics
bagage
reviewed
Nov 16, 2024
| `<td class="track-analysis-distance track-analysis-distance-total">${this.formatDistance( | ||
| totalDistance | ||
| )} km</td>` | ||
| )} ${i18next.t('footer.kilometer-abbrev')}</td>` |
Collaborator
There was a problem hiding this comment.
Thanks for the PR! If you are done, do not forget to:
- add dynamic i18n keys in
locales/keys.js - run
gulp i18nextto regenerate English translations - I'll push the new content to Transifex then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added translation of track in analytics