Add CEAFm and less strict CoNLL reader#8
Open
andreasvc wants to merge 7 commits intons-moosavi:masterfrom
Open
Add CEAFm and less strict CoNLL reader#8andreasvc wants to merge 7 commits intons-moosavi:masterfrom
andreasvc wants to merge 7 commits intons-moosavi:masterfrom
Conversation
Allow the following:
#begin document (malformed);
malformed 0 0 a (0
malformed 0 1 b 0
malformed 0 2 c 0|(1
malformed 0 3 d 0)|1)
malformed 0 4 e -
malformed 0 8 . -
#end document
Clean up code formatting; remove executable bits
This CoNLL reader didn't support coreference columns without "|" as separator, which apparently is allowed. This reverts commit e692532.
- 3x speedup of CEAF by using sets instead of lists - skip numbers without opening or ending paren: "1|2)" (instead of exiting) - code formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous pull request failed the tests, don't know how I overlooked that ...
This version is updated to the packaged version of coval and includes CEAFm, faster CEAF, less strict CoNLL reader, and passes tests.
Cheers