Skip to content

fix(zone): create_version fix #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnavbhattacharya-NS1 merged 1 commit into from
Aug 8, 2025
Merged

fix(zone): create_version fix #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ns1/rest/zones.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,21 @@ def list_versions(self, zone, callback=None, errback=None):
errback=errback,
)

def create_version(self, zone, force=False, callback=None, errback=None):
def create_version(
self, zone, force=False, callback=None, errback=None, name=None
):
if name is None:
name = zone
body = {}
body["name"] = name

request = "{}/{}/versions?force={}".format(
self.ROOT, zone, str.lower(str(force))
)
return self._make_request(
"PUT",
request,
params={},
body=body,
callback=callback,
errback=errback,
)
Expand Down
9 changes: 5 additions & 4 deletions tests/unit/test_zone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,14 +193,15 @@ def cb():


@pytest.mark.parametrize(
"zone, url", [("test.zone", "zones/test.zone/versions?force=false")]
"zone, url, name",
[("test.zone", "zones/test.zone/versions?force=false", "new.zone")],
)
def test_rest_zone_version_create(zones_config, zone, url):
def test_rest_zone_version_create(zones_config, zone, url, name):
z = ns1.rest.zones.Zones(zones_config)
z._make_request = mock.MagicMock()
z.create_version(zone)
z.create_version(zone, name=name)
z._make_request.assert_called_once_with(
"PUT", url, params={}, callback=None, errback=None
"PUT", url, body={"name": name}, callback=None, errback=None
)


Expand Down