Small fix of the KTools::inverseOf() return type#13
Open
victorpopkov wants to merge 1 commit intonsimplex:masterfrom
Open
Small fix of the KTools::inverseOf() return type#13victorpopkov wants to merge 1 commit intonsimplex:masterfrom
victorpopkov wants to merge 1 commit intonsimplex:masterfrom
Conversation
oxr463
approved these changes
Jun 29, 2020
710lucas
approved these changes
Dec 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the #12 as I've faced that one as well (Debian 8.3.0-6, gcc 8.3.0):
Scanning dependencies of target ktool_common [ 3%] Building CXX object CMakeFiles/ktool_common.dir/src/common/ktools_common.cpp.o [ 6%] Building CXX object CMakeFiles/ktool_common.dir/src/common/file_abstraction.cpp.o [ 10%] Building CXX object CMakeFiles/ktool_common.dir/src/common/ktex/ktex.cpp.o [ 13%] Building CXX object CMakeFiles/ktool_common.dir/src/common/ktex/specs.cpp.o [ 16%] Building CXX object CMakeFiles/ktool_common.dir/src/common/atlas.cpp.o In file included from /tmp/ktools-4.4.0/src/common/atlas.hpp:24, from /tmp/ktools-4.4.0/src/common/atlas.cpp:18: /tmp/ktools-4.4.0/src/common/algebra.hpp: In function 'void KTools::inverseOf(const KTools::ProjectiveMatrix<2, T>&)': /tmp/ktools-4.4.0/src/common/algebra.hpp:405:10: error: return-statement with a value, in function returning 'void' [-fpermissive] return N; ^ make[2]: *** [CMakeFiles/ktool_common.dir/build.make:115: CMakeFiles/ktool_common.dir/src/common/atlas.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:183: CMakeFiles/ktool_common.dir/all] Error 2 make: *** [Makefile:130: all] Error 2