adm: add `mainchain update-contract` command by End-rey · Pull Request #3799 · nspcc-dev/neofs-node

End-rey · 2026-02-03T14:26:00Z

Closes #3464.

codecov · 2026-02-03T14:32:13Z

Codecov Report

❌ Patch coverage is 0% with 209 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.41%. Comparing base (827cad9) to head (fccb48d).

Files with missing lines	Patch %	Lines
cmd/neofs-adm/internal/modules/mainchain/update.go	0.00%	182 Missing ⚠️
...d/neofs-adm/internal/modules/fschain/initialize.go	0.00%	5 Missing ⚠️
cmd/neofs-adm/internal/modules/mainchain/root.go	0.00%	3 Missing ⚠️
cmd/neofs-adm/internal/modules/fschain/balance.go	0.00%	2 Missing ⚠️
...md/neofs-adm/internal/modules/fschain/container.go	0.00%	2 Missing ⚠️
cmd/neofs-adm/internal/modules/fschain/load.go	0.00%	2 Missing ⚠️
cmd/neofs-adm/internal/modules/fschain/quota.go	0.00%	2 Missing ⚠️
...s-adm/internal/modules/fschain/verified_domains.go	0.00%	2 Missing ⚠️
cmd/neofs-adm/internal/modules/fschain/config.go	0.00%	1 Missing ⚠️
.../neofs-adm/internal/modules/fschain/dump_hashes.go	0.00%	1 Missing ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3799      +/-   ##
==========================================
- Coverage   25.52%   25.41%   -0.12%     
==========================================
  Files         660      662       +2     
  Lines       42636    42822     +186     
==========================================
- Hits        10884    10883       -1     
- Misses      30749    30937     +188     
+ Partials     1003     1002       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Instead of several `neo-go` commands to create update contract transaction in the main chain and sign them, it allows using a single `adm` command. Closes #3464. Signed-off-by: Andrey Butusov <andrey@nspcc.io>

carpawell · 2026-02-05T16:20:01Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+
+	gasWalletPath, _ := cmd.Flags().GetString(gasWalletFlag)
+	if gasWalletPath == "" {
+		return errors.New("gas wallet is required (use --gas-wallet flag)")


can be a flag const and fmt.Errorf

carpawell · 2026-02-05T16:22:55Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+	}
+
+	w := io2.NewBufBinWriter()
+	emit.AppCall(w.BinWriter, contractHash, "update", callflag.All, nefBytes, manifestBytes, data)


@roman-khimov , @AnnaShaleva, cant this be simpler to update a contract? rpc bingings or smth. likely, no emit package and manual invocation scripts should be used, and most of the things should be done much easier, try to look at https://github.com/nspcc-dev/neofs-contract/blob/f228d5018923fa9d6d14bf363670e9159c0e79c7/rpc/neofs/rpcbinding.go#L106

Yes, NEP-22 bindings better be used here.

carpawell · 2026-02-05T16:25:20Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+	cmd.Printf("Transaction sent successfully!\n")
+	cmd.Printf("Transaction hash: %s\n", txHash.StringLE())
+
+	await, _ := cmd.Flags().GetBool(awaitFlag)


i feel like any update should be in await mode always, no need for this to be flag'ed

carpawell · 2026-02-05T16:27:27Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+
+func waitForTxMainChain(c fschain.Client, hash util.Uint256, vub uint32) error {
+	for range maxAttemptsTxWait {
+		time.Sleep(time.Second)


no Waiter functionality used? manual for and sleep? i think we need to try to use the new neo-go API for such things

roman-khimov · 2026-02-06T12:00:52Z

cmd/neofs-adm/internal/modules/fschain/n3client.go


-func getN3Client(v *viper.Viper) (*rpcclient.Client, error) {
+// GetN3Client creates and initializes neo-go RPC client using configuration from viper.
+func GetN3Client(v *viper.Viper) (*rpcclient.Client, error) {


I'd suggest moving this into some common package reused by fschain and mainchain.

roman-khimov · 2026-02-06T12:01:41Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+	"github.com/nspcc-dev/neo-go/pkg/config/netmode"
+	"github.com/nspcc-dev/neo-go/pkg/core/transaction"
+	"github.com/nspcc-dev/neo-go/pkg/encoding/address"
+	io2 "github.com/nspcc-dev/neo-go/pkg/io"


It's the only io here.

roman-khimov · 2026-02-06T12:02:38Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+	}
+
+	w := io2.NewBufBinWriter()
+	emit.AppCall(w.BinWriter, contractHash, "update", callflag.All, nefBytes, manifestBytes, data)


Yes, NEP-22 bindings better be used here.

roman-khimov · 2026-02-06T12:14:04Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+	manifestFlag        = "manifest"
+	dataFlag            = "data"
+	awaitFlag           = "await"
+	gasWalletFlag       = "gas-wallet"


sender-wallet

roman-khimov · 2026-02-06T12:16:02Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+	if err != nil {
+		return fmt.Errorf("can't open gas wallet: %w", err)
+	}
+	gasAcc, err := fschain.GetWalletAccount(gasWallet, "single")


Most likely it has no label. Just pick the default one from the wallet.

roman-khimov · 2026-02-06T12:17:07Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+		return fmt.Errorf("can't create N3 client: %w", err)
+	}
+
+	committeeAcc, err := fschain.GetWalletAccount(wallets[0], committeeAccountName)


In this context it's not committee, it's IR. Although wallets do have it normally (at least until nodes remain the same).

roman-khimov · 2026-02-06T12:17:24Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+		{
+			Signer: transaction.Signer{
+				Account: gasAcc.Contract.ScriptHash(),
+				Scopes:  transaction.CalledByEntry,


None, it doesn't need any proper scope.

roman-khimov · 2026-02-06T12:18:21Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+		VerificationScript: gasAcc.Contract.Script,
+	}
+	gasScriptHash := gasAcc.Contract.ScriptHash()
+	for i := range tx.Signers {


But there is acc.SignTx() that should do the thing.

roman-khimov · 2026-02-06T12:18:52Z

cmd/neofs-adm/internal/modules/mainchain/update.go

+		return fmt.Errorf("incomplete signature: %w", err)
+	}
+
+	for i := range tx.Signers {


You know your signers exactly.

End-rey self-assigned this Feb 3, 2026

End-rey requested review from carpawell, cthulhu-rider and roman-khimov as code owners February 3, 2026 14:26

End-rey force-pushed the adm-update-chain-contract branch from 866b45b to 9f6b6a1 Compare February 3, 2026 14:28

End-rey force-pushed the adm-update-chain-contract branch from 9f6b6a1 to fccb48d Compare February 4, 2026 14:37

adm: add mainchain update-contract command

fccb48d

Instead of several `neo-go` commands to create update contract transaction in the main chain and sign them, it allows using a single `adm` command. Closes #3464. Signed-off-by: Andrey Butusov <andrey@nspcc.io>

carpawell reviewed Feb 5, 2026

View reviewed changes

roman-khimov reviewed Feb 6, 2026

View reviewed changes

Conversation

End-rey commented Feb 3, 2026

Uh oh!

codecov bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Feb 3, 2026 •

edited

Loading