sn/storage: Fix unclosed compressed files in FSTree#3802
Merged
cthulhu-rider merged 1 commit intomasterfrom Feb 6, 2026
Merged
sn/storage: Fix unclosed compressed files in FSTree#3802cthulhu-rider merged 1 commit intomasterfrom
FSTree#3802cthulhu-rider merged 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3802 +/- ##
=======================================
Coverage 25.52% 25.52%
=======================================
Files 660 661 +1
Lines 42636 42641 +5
=======================================
+ Hits 10884 10886 +2
- Misses 30749 30752 +3
Partials 1003 1003 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
cthulhu-rider
force-pushed
the
fstree-compress-close
branch
2 times, most recently
from
563aff1 to
7b50cff
Compare
The zstd decoder does not close original stream. Previously, `os.File.Close()` were never called for compressed files bigger than 16K. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
fstree-compress-close
branch
from
7b50cff to
cb23512
Compare
roman-khimov
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.