fix(dock): prevent dock from overlapping page content#106
Open
seanrw93 wants to merge 2 commits intonst-sdc:mainfrom
Open
fix(dock): prevent dock from overlapping page content#106seanrw93 wants to merge 2 commits intonst-sdc:mainfrom
seanrw93 wants to merge 2 commits intonst-sdc:mainfrom
Conversation
The bottom navigation dock could overlap page content near the bottom of the viewport, particularly on mobile screens. This change adds spacing at the page wrapper level to keep content fully readable while preserving the existing dock behavior on larger screens.
There was a problem hiding this comment.
Pull request overview
Fixes bottom navigation dock overlap by adding bottom spacing to page wrappers and adjusting the dock container to better fit mobile/desktop layouts.
Changes:
- Added bottom padding to key pages to keep content above the fixed dock
- Updated dock positioning to be full-width on mobile and centered on larger screens
- Tweaked dock item sizing/rounding for improved responsiveness
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/pages/TrackShuttle.jsx | Adds bottom padding to the page wrapper to prevent dock overlap |
| frontend/src/pages/Signup.jsx | Adds bottom padding to the layout container to prevent dock overlap |
| frontend/src/pages/Login.jsx | Adds bottom padding to the layout container to prevent dock overlap |
| frontend/src/pages/Home.jsx | Adds bottom padding to the home layout container to prevent dock overlap |
| frontend/src/components/Footer.jsx | Makes the dock full-width on mobile, centered on larger screens, and adjusts styling/spacing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return ( | ||
| <div className="min-h-[calc(100vh-80px)] w-full flex flex-col justify-center relative overflow-hidden"> | ||
| /* Padding prevents overlap with fixed bottom dock */ | ||
| <div className="min-h-[calc(100vh-80px)] pb-20 sm:pb-24 w-full flex flex-col justify-center relative overflow-hidden"> |
There was a problem hiding this comment.
The dock-spacing values (pb-20 sm:pb-24) are duplicated across multiple pages, which risks drift if the dock height/spacing changes again. Consider centralizing this into a shared layout wrapper component or a Tailwind utility (e.g., a custom class like pb-dock) so the padding is defined in one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the bottom navigation dock could overlap page content near the bottom of the viewport, particularly on mobile and authenticated pages.
The fix ensures content is pushed above the fixed navigation with appropriate spacing, preventing overlap while preserving the existing dock behavior.
How this addresses the issue
This change satisfies the following acceptance criteria:
Push the content above the navigation with proper spacing
Content wrappers now include bottom spacing to account for the fixed dock, ensuring the last elements remain visible and accessible.
Responsive behavior
The dock remains fixed as intended, while layout spacing adapts correctly across screen sizes and page types.
What was changed
Testing
Verified locally on:
Tested on:
** Related issue**
Fixes #105