DON'T MERGE: Fixed camera not opening from modal on iOS#46
Open
surdu wants to merge 2 commits into
Open
Conversation
surdu
changed the title
Contributor
Author
|
There is still an issue here of not being able to select a picture anymore from a modal. A temporary fix for now for us is to comment this line. We'll try to find a proper solution soon ... |
Contributor
|
@surdu - still not ready to merge correct? |
Contributor
Author
|
@bradmartin correct 😞 |
Contributor
Author
|
Hmm... It appears the problem was on our code, because we where not showing the modal the "correct" way, using the new approach with the frame. That being said, please still don't merge this yet as I want to add a button in the demo app to showcase the modal behaviour (and/or update the docs). |
Contributor
Author
|
@nickykln If I remember correctly, this fixed the problem. I just have to remember specifically what was still needed for this PR (it was some time since I didn't used this) and should be good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15 & #30