Add Webex STUN sub-classification via SOFTWARE attribute#3194
Merged
Conversation
Webex call media uses ICE/STUN. The STUN control flows were reported as STUN/Network because the STUN dissector had no Webex sub-classification hook even though the media servers already fall in the known Webex IP ranges. Webex (formerly Cisco Spark) ICE agents advertise the STUN SOFTWARE attribute (0x8022) with the value "Cisco-Spark". Parse it in is_stun() and set the app protocol to the existing Webex protocol so the flow classifies as STUN.Webex (VoIP) with DPI confidence. Add a minimal test capture and its expected result. Signed-off-by: Chad Monroe <chad@monroe.io>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please sign (check) the below before submitting the Pull Request:
Link to the related issue:
Describe changes:
Webex call media uses ICE/STUN. The STUN control flows were reported as STUN/Network because the STUN dissector had no Webex sub-classification hook even though the media servers already fall in the known Webex IP ranges.
Webex (formerly Cisco Spark) ICE agents advertise the STUN SOFTWARE attribute (0x8022) with the value "Cisco-Spark". Parse it in is_stun() and set the app protocol to the existing Webex protocol so the flow classifies as STUN.Webex (VoIP) with DPI confidence.
Add a minimal test capture and its expected result.