Experimenting with stubs for mixins' methods on the base class#64
Open
DmitrySharabin wants to merge 5 commits intoclass-mixinsfrom
Open
Experimenting with stubs for mixins' methods on the base class#64DmitrySharabin wants to merge 5 commits intoclass-mixinsfrom
DmitrySharabin wants to merge 5 commits intoclass-mixinsfrom
Conversation
LeaVerou
reviewed
Nov 3, 2025
Contributor
LeaVerou
left a comment
LeaVerou
left a comment
There was a problem hiding this comment.
Nice but we should not special case to init — what do we do when two mixins happen to define the same method? What about other lifecycle hooks, like connectedCallback()?
The test should be "does the host class have this method?" not "does the host class have init?"
DmitrySharabin
force-pushed
the
rudimentary-init
branch
from
da1a6e6 to
b2ec6d4
Compare
DmitrySharabin
changed the title
init()
LeaVerou
reviewed
Nov 3, 2025
They are always applicable.
LeaVerou
force-pushed
the
class-mixins
branch
from
b1aba24 to
6bdfd47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.