ci: block the zero-leak gate on router-field and wit-namespace scans#450
Conversation
lgahdl
left a comment
lgahdl
left a comment
There was a problem hiding this comment.
The new foreign-WIT-namespace scan is clean and correctly uses the current videre: namespace alongside the old ones, so it would actually catch a real leak. The zero_leak.rs integration test is a genuine functional oracle too (boots via Supervisor::boot, asserts real status-transition delivery), not a shallow smoke test — though note it doesn't itself invoke check-venue-agnostic.sh, so it can't catch problems in the scans below.
Two of the scans this gate now BLOCKS on can never actually fail, which matters a lot more now that this is a hard gate instead of advisory:
-
The pre-existing charter-symbol scan (unchanged by this diff, flagged already on #449) still checks only pre-rename dead names (
nexum:intent,nexum:adapter,PoolRouter) and never the current post-rename vocabulary (videre:types,VenueRegistry,VenueActor,VenueId). That finding's severity goes up here: a scan that can't catch a real leak is now blocking every PR's CI while providing zero actual protection on that axis. -
The new router-field scan has the same problem in a new spot.
fa920ed to
76bcb9e
Compare
16a6724 to
8706226
Compare
Drop continue-on-error from the venue-agnostic job, add privileged-field and host-WIT namespace scans to the zero-leak script, and pin the invariant with two integration tests: the echo venue boots and routes a worker's submission purely through the generic extension seam, and the nexum-runtime crate graph names no venue-shaped crate. A missing wasm fixture hard-fails the boot oracle under CI so the gate cannot skip itself.
|
Superseded at HEAD. This PR was rippled onto the merged #449 (which carries my charter fix), so the scan now uses the post-rename set |
8706226 to
cc831bb
Compare
2 participants
Closes #385
What
Flips the venue-agnostic CI check from advisory to blocking, extends
scripts/check-venue-agnostic.shwith a privileged router-field scan and a foreign-WIT-namespace scan, and adds an echo-venue boot integration test as the oracle.Why
A go/no-go gate before repos are cut: the host must boot the echo venue and route a submission through the generic extension seam with no venue/intent/cow crate, charter symbol, router field, or foreign WIT namespace anywhere in its graph.
Testing
just check-venue-agnosticcargo test -p videre-host --test zero_leakAI Assistance
Implemented with Claude Code.
Closes #385