fix(sign-image): login to ecr public before signing so cosign can push the signature#74
Merged
Merged
Conversation
davidf-null
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Login to Amazon ECR Publicstep inside the composite action, betweenConfigure AWS credentialsandInstall cosignconfigure-aws-credentials) inside the action so callers don't need to manage prerequisitesRoot cause
Sign jobs in k8s-tools run on a fresh runner separate from the build job. The ECR login done during the build is not available in the sign job. The composite action needs to handle its own ECR auth.