Skip to content

fix(sign-image): login to ecr public before signing so cosign can push the signature#74

Merged
null-paorodrigues merged 1 commit into
mainfrom
fix/sign-image-ecr-login
May 21, 2026
Merged

fix(sign-image): login to ecr public before signing so cosign can push the signature#74
null-paorodrigues merged 1 commit into
mainfrom
fix/sign-image-ecr-login

Conversation

@null-paorodrigues

Copy link
Copy Markdown
Contributor

Summary

  • Adds Login to Amazon ECR Public step inside the composite action, between Configure AWS credentials and Install cosign
  • cosign stores signatures as OCI artifacts in the same ECR repo — without an explicit ECR Public login, the push fails with 401 Unauthorized
  • Consistent with the existing design decision of keeping all auth setup (including configure-aws-credentials) inside the action so callers don't need to manage prerequisites

Root cause

Sign jobs in k8s-tools run on a fresh runner separate from the build job. The ECR login done during the build is not available in the sign job. The composite action needs to handle its own ECR auth.

@null-paorodrigues null-paorodrigues merged commit 57c5ce2 into main May 21, 2026
2 checks passed
@null-paorodrigues null-paorodrigues deleted the fix/sign-image-ecr-login branch May 21, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants