chore(release): harden update-version.sh with set -euo pipefail#21
Merged
Conversation
Without these, the release script silently continued past failures (e.g. a failed `git push origin main` would not stop the subsequent `git tag` / `git push origin v1 --force`, leaving the local repo with tags that were never published or a remote commit without its tag). Adds a bash shebang too so `pipefail` is guaranteed available. No behavior change on the happy path — the existing `if git rev-parse` idiom is set -e safe. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#!/usr/bin/env bashshebang andset -euo pipefailtoupdate-version.sh.git push origin mainwould not stop the subsequentgit tag/git push origin v1 --force, leaving the local repo with tags that were never published, or a remote commit without its tag.Why now
Discovered during the v1.2.0 release prep for #20. No behavior change on the happy path — the existing
if git rev-parse ...idiom isset -e-safe becauseset -edoes not trigger inside conditionals.Test plan
bash -n update-version.sh(syntax OK)🤖 Generated with Claude Code