feat(client-689): application or metrics logs #144
Merged
Conversation
…ggle - Add applicationLogs.enabled flag (false disables all app log forwarding, keeping only http/sys metrics pipelines active) - Add mountDockerContainers flag for Docker runtime support (e.g. Minikube) - Add logsEnabled/metricsEnabled per-provider for datadog, newrelic, dynatrace instead of hardcoded 'true' - Update default controller image to beta-295461e Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Existing releases without applicationLogs in their values would evaluate 'not nil' as true, incorrectly disabling application logs. Using (.Values.logging.applicationLogs).enabled | default true ensures the field defaults to enabled when missing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Helm's default function treats false as empty, so false | default true returns true, making it impossible to explicitly disable application logs. Using kindIs "bool" correctly distinguishes nil (field absent) from an explicit false value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
davidf-null
requested review from
agustincelentano,
gdrojas and
sebastiancorrea81
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sebastiancorrea81
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added support for enabling and disabling application or metrics logs.