chore(endpoint-exposer): remove unused groups field from service spec#14
Merged
Conversation
The `groups` property was declared on each route in the Endpoint Exposer service spec but never consumed by any workflow, script, or Istio template — it was a dead UI field with no enforcement. Drop the property, its uiSchema Controls, and the stale documentation/examples that referenced it across all five schema copies (attributes + create/delete parameters + results). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… spec The inline `action_specifications` array was ignored by the tofu `service_definition` module, which only reads `attributes`, `use_default_actions`, `selectors`, `available_actions` and `available_links` from the service spec and registers actions from separate `specs/actions/*.json.tpl` files. The ~845-line block was documentation-only noise that suggested custom actions were registered when none were. Lifecycle actions keep coming from `use_default_actions: true`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
agustincelentano
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
groupsproperty from every route in the Endpoint Exposer service spec. The field was declared but never consumed by any workflow, script, or Istio template.uiSchemaControls (Required Endpoint Permissions/Groups) so JSON Forms no longer renders a multi-select that goes nowhere.Labelmarkdown (Route Configuration table column and Public/Private route examples) so docs don't reference a field that no longer exists.