Skip to content

chore(endpoint-exposer): remove unused groups field from service spec#14

Merged
agustincelentano merged 2 commits into
mainfrom
chore/clean-groups-from-spec
Apr 22, 2026
Merged

chore(endpoint-exposer): remove unused groups field from service spec#14
agustincelentano merged 2 commits into
mainfrom
chore/clean-groups-from-spec

Conversation

@javi-null

@javi-null javi-null commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the groups property from every route in the Endpoint Exposer service spec. The field was declared but never consumed by any workflow, script, or Istio template.
  • Drops the associated uiSchema Controls (Required Endpoint Permissions / Groups) so JSON Forms no longer renders a multi-select that goes nowhere.
  • Cleans up stale documentation in the inline Label markdown (Route Configuration table column and Public/Private route examples) so docs don't reference a field that no longer exists.

javi-null and others added 2 commits April 22, 2026 11:48
The `groups` property was declared on each route in the Endpoint Exposer
service spec but never consumed by any workflow, script, or Istio
template — it was a dead UI field with no enforcement. Drop the property,
its uiSchema Controls, and the stale documentation/examples that
referenced it across all five schema copies (attributes + create/delete
parameters + results).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… spec

The inline `action_specifications` array was ignored by the tofu
`service_definition` module, which only reads `attributes`,
`use_default_actions`, `selectors`, `available_actions` and
`available_links` from the service spec and registers actions from
separate `specs/actions/*.json.tpl` files. The ~845-line block was
documentation-only noise that suggested custom actions were registered
when none were. Lifecycle actions keep coming from
`use_default_actions: true`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@agustincelentano agustincelentano merged commit 789cfcc into main Apr 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants