fix(ecr): add cross-account pull and repository policy support#384
Merged
Conversation
- infrastructure/aws/iam/ecr: add ecr_repository_policy output that generates the ECR repo policy JSON from pull_account_ids when enable_cross_account_pull is true - nullplatform/asset/ecr: add cross_account_pull_role_arn variable that populates the read.role_arn field in the provider config, enabling np_aws_ecr_assume_role on deployments - nullplatform/asset/ecr: add repository_policy variable that populates setup.policy, applied by Nullplatform on every new ECR repo created - nullplatform/asset/ecr: add naming_rule variable with Nullplatform default to avoid perpetual drift caused by the server-side injected field Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
agustincelentano
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infrastructure/aws/iam/ecr: add ecr_repository_policy output that generates the ECR repo policy JSON from pull_account_ids when enable_cross_account_pull is true
nullplatform/asset/ecr: add cross_account_pull_role_arn variable that populates the read.role_arn field in the provider config, enabling np_aws_ecr_assume_role on deployments
nullplatform/asset/ecr: add repository_policy variable that populates setup.policy, applied by Nullplatform on every new ECR repo created
nullplatform/asset/ecr: add naming_rule variable with Nullplatform default to avoid perpetual drift caused by the server-side injected field