Skip to content

Updated Target Frameworks to: netstandard2.0, net 4.6.2, net 6, net 7#7

Open
SpaceOgre wants to merge 7 commits intonullptre:masterfrom
SpaceOgre:feature/net7
Open

Updated Target Frameworks to: netstandard2.0, net 4.6.2, net 6, net 7#7
SpaceOgre wants to merge 7 commits intonullptre:masterfrom
SpaceOgre:feature/net7

Conversation

@SpaceOgre
Copy link

@SpaceOgre SpaceOgre commented Mar 6, 2023

The following is done in this PR

Fixes: #6

  • Updated the target frameworks to:
    • netstandard 2.0
    • net4.6.2
    • net6.0
    • net7.0
  • Changed testing framework to xUnit (this is the recommended framework by Microsoft these days)
    • Added some more test cases
  • Added support for DefaultExpression
  • Cleaned the code in the Comparer class
    • Using pattern matching
    • Adding else to the if-statemensts since only one can be true
    • Using Lazy-evaluation for IsAnonymousType
    • TryCalculateConstant is only done for y if the call to TryCalculateConstant(x) returns IsDefined == true
  • Added an .editorconfig file based on the one used by Microsoft for .Net Core

@SpaceOgre
Copy link
Author

If you like this PR I think it would be best to merge it with a Squash, the commit history is not that nice :)

@nullptre
Copy link
Owner

nullptre commented Mar 7, 2023

Thanks @SpaceOgre, I didn't check it yet though, and I'm planning to dedicate some time this weekend for the PR. Pls let me know how long you can wait.

@SpaceOgre
Copy link
Author

@yuriy-nelipovich it is your repository 😉
I dont need it yet for a time so no hurry from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to .Net 7 and modernize the code where possible

2 participants