TST: Try building maintenance/2.3.x branch#15
Conversation
rgommers
left a comment
There was a problem hiding this comment.
This change looks fine to me, should do the job. Build logs show it builds 2.3.4, that's because the .dev0 gets dropped from the visible logging.
Should be good to merge if CI comes back green.
It did that even before it was tagged. I think it got that version from the pyproject.toml file. |
|
@rgommers I updated cibuildwheel, missed that. I'm thinking it might be worth adding dependabot just to track updates in the EDIT: Or maybe just figure out how to keep the requirements in numpy. |
Indeed, see gh-6.
That wouldn't be good. The requirements here are the minimal build/test requirements and 100% of them are pinned. Part of the point of this repo is to minimize what gets pulled in to reduce the supply chain security surface. I'm thinking more like a check that runs before the wheel builds kick off that checks the important ones (OpenBLAS in particular) for equality between this repo and the main repo. I'll have a look at it now. |
|
For completeness: there are no overlapping license files, the ones needed for NumPy sources are only in the main repo, the ones needed for vendoring/distributing are only in this repo. |
No description provided.